dimas-b commented on code in PR #2762:
URL: https://github.com/apache/polaris/pull/2762#discussion_r2408104663
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/DatabaseType.java:
##########
@@ -53,9 +54,10 @@ public static DatabaseType fromDisplayName(String
displayName) {
* caller.
*/
public InputStream openInitScriptResource(@Nonnull SchemaOptions
schemaOptions) {
- if (schemaOptions.schemaFile() != null) {
+ if (schemaOptions.schemaFile() != null
+ && !Objects.requireNonNull(schemaOptions.schemaFile()).isEmpty()) {
Review Comment:
If `SchemaOptions` validated (and did not permit) empty values, we'd not
have to validate here (even better with `Optional`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
