HonahX commented on code in PR #2800: URL: https://github.com/apache/polaris/pull/2800#discussion_r2427412972
########## client/python/pyproject.toml: ########## @@ -45,7 +45,7 @@ repository = "https://github.com/apache/polaris/"; polaris = "cli.polaris_cli:main" [tool.poetry] -requires-poetry = "==2.1.4" +requires-poetry = ">=2.1.4" Review Comment: How about we still pin the poetry version but upgrade it to latest for example. Ideally this can help reduce confusion caused by tool version mismatch ########## client/python/pyproject.toml: ########## @@ -61,19 +61,15 @@ types-python-dateutil = ">= 2.8.19.14" mypy = ">=1.18, <=1.18.2" pyiceberg = "==0.10.0" pre-commit = "==4.3.0" -openapi-generator-cli = "==7.15.0" +openapi-generator-cli = "==7.12.0" Review Comment: It will be good if we upgrade the generator version along with the one we used in java: https://github.com/apache/polaris/blob/dbc21a3d289e140090f621838c664062ba0122e3/gradle/libs.versions.toml#L115 Let's keep it 7.12 for this PR : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
