flyrain commented on code in PR #2680:
URL: https://github.com/apache/polaris/pull/2680#discussion_r2418034610
##########
polaris-core/build.gradle.kts:
##########
@@ -24,6 +24,7 @@ plugins {
dependencies {
implementation(project(":polaris-api-management-model"))
+ implementation(libs.apache.httpclient5)
Review Comment:
> I believe it would be valuable to isolate OPA from core and from
runtime/service and only include it into runtime/server.
> the new authorizer is pluggable, but not all downstream projects may want
to have it by default.
I'm OK to move OPA related classes from core to `runtime/service`, but I
don't think we should put it in `runtime/server`. Here are the reason:
1. I think it's perfect fine to have another implementation of authorizer,
we did that in multiple places.
2. The native RBAC is still the default.
3. There is no single extra lib dependencies introduced when it landed in
the `service` module. `http` and `jwt` libs are there already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
