snazy commented on code in PR #2728: URL: https://github.com/apache/polaris/pull/2728#discussion_r2439126725
########## persistence/nosql/nodes/api/src/main/java/org/apache/polaris/nodes/api/Node.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.nodes.api; Review Comment: While the main API interface mentions `API to lease node IDs...`, the use cases are not limited to that sole use case. Other IMHO interesting use cases are to get an overview of the active processes (= nodes) of a single Polaris cluster. Adding too specific use cases or even specific call-sites to the package name(s) feels like restricting the use cases. I'd prefer to keep the current packages names. I'm okay to rename the packages to `org.apache.polaris.nodeleases.*` or `org.apache.polaris.nodeids.*` though. But the whole effort isn't user-facing at all, so later renames are possible w/o the risk of breaking anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
