vchag commented on issue #2630: URL: https://github.com/apache/polaris/issues/2630#issuecomment-3379456764
Thanks @adutra ! ... a few thoughts; curious for your take. 1. Currently `PropertyMapEventListener` the name makes it sound like a generic event listener but it only overrides `onAfterRefreshTable`, which does look odd. If the intent was to only care about `AfterRefreshTableEvent` then I think we should rename `PropertyMapEventListener` to `AfterRefreshTableEventListener`, any thoughts? 2. Properties parameter `HashMap` -> `Map`: This becomes moot if we agree on #3. 3. `events` -> `maps` -> `JSON`: Since the target serialization format is Json, the extra hope is unnecessary. Direct Jackson annotations will couple the event classes to JSON and hinder future Avro/Protobuf support. let’s use Jackson Mixins instead to keep the models serializer agnostic while still producing consistent JSON? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
