XJDKC commented on code in PR #2759: URL: https://github.com/apache/polaris/pull/2759#discussion_r2407769896
########## polaris-core/src/main/java/org/apache/polaris/core/credentials/PolarisCredentialManager.java: ########## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.credentials; + +import org.apache.polaris.core.connection.AuthenticationParametersDpo; +import org.apache.polaris.core.credentials.connection.ConnectionCredentialVendor; +import org.apache.polaris.core.identity.credential.ServiceIdentityCredential; +import org.apache.polaris.core.identity.provider.ServiceIdentityProvider; + +/** + * PolarisCredentialManager is responsible for retrieving the credentials Polaris needs to access + * remote services such as federated catalogs and cloud storage. + * + * <p>It delegates to {@link ConnectionCredentialVendor} implementations that combine + * service-managed identity information (e.g., an IAM user Polaris uses) with user-defined + * authentication parameters (e.g., roleArn) to generate the credentials required for authentication + * with external systems. + * + * <p>Typical flow for connection credentials: + * + * <ol> + * <li>The manager selects the appropriate {@link ConnectionCredentialVendor} based on the + * authentication type from the {@link AuthenticationParametersDpo}. + * <li>The vendor resolves the service identity using {@link ServiceIdentityProvider} to obtain a + * {@link ServiceIdentityCredential}. + * <li>The vendor uses the service identity credential together with user-provided authentication + * parameters to obtain temporary access credentials (e.g., via AWS STS AssumeRole). + * </ol> + * + * <p>This design supports both SaaS and self-managed deployments, ensuring a clear separation + * between user-provided configuration and Polaris-managed identity. In the future, this interface + * will be extended to also manage storage credentials, providing a unified interface for all + * credential management needs. + */ +public interface PolarisCredentialManager extends ConnectionCredentialVendor {} Review Comment: Because in the future, it will implement the `StoargeCredentialVendor`. ########## polaris-core/src/main/java/org/apache/polaris/core/credentials/connection/ConnectionCredentialProperty.java: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.core.credentials.connection; + +import org.apache.iceberg.aws.AwsProperties; + +/** + * A subset of Iceberg catalog properties recognized by Polaris. + * + * <p>Most of these properties are meant to initialize Catalog objects for accessing the remote + * Catalog service. + */ +public enum ConnectionCredentialProperty { + AWS_ACCESS_KEY_ID(String.class, AwsProperties.REST_ACCESS_KEY_ID, "the aws access key id", true), Review Comment: Sounds good! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
