dimas-b commented on code in PR #32:
URL: https://github.com/apache/polaris-tools/pull/32#discussion_r2402909117
##########
iceberg-catalog-migrator/api-test/src/main/java/org/apache/polaris/iceberg/catalog/migrator/api/test/AbstractTest.java:
##########
@@ -55,8 +55,8 @@ public abstract class AbstractTest {
protected static final Namespace NS_A_B_C_D = Namespace.of("a", "b", "c",
"d");
protected static final Namespace NS_A_B_C_D_E = Namespace.of("a", "b", "c",
"d", "e");
- private static String sourceCatalogWarehouse;
- private static String targetCatalogWarehouse;
+ protected static String sourceCatalogWarehouse;
Review Comment:
I'm generally not in favour of access to non-final fields outside of the
declaring class. I believe it complicates refactoring and make code analysis
harder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
