singhpk234 commented on code in PR #2757: URL: https://github.com/apache/polaris/pull/2757#discussion_r2402440000
########## runtime/defaults/src/main/resources/application.properties: ########## @@ -146,6 +145,9 @@ polaris.metrics.tags.application=Polaris # polaris.metrics.tags.environment=prod # polaris.metrics.tags.region=us-west-2 +polaris.tracing.request-id-generator.type=default +polaris.tracing.request-id-generator.header-name=Polaris-Request-Id Review Comment: minor / optional : does the header name has to to do anything with the generator, wondering if we just reuse the name we had earlier, WDYT ? ```suggestion polaris.tracing.request-id-header-name=Polaris-Request-Id ``` ########## runtime/service/src/main/resources/META-INF/services/io.smallrye.config.ConfigSourceInterceptor: ########## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +org.apache.polaris.service.config.ConfigRelocationInterceptor Review Comment: nit : newline ? ########## CHANGELOG.md: ########## @@ -53,6 +53,9 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti ### Deprecations * The property `polaris.active-roles-provider.type` is deprecated and has no effect anymore. +* The property `polaris.log.request-id-header-name` has been renamed to + `polaris.tracing.request-id-generator.header-name`; the old name is still supported for backwards + compatibility, but will generate a warning. Review Comment: should we use word deperecated ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
