eric-maynard commented on code in PR #2765:
URL: https://github.com/apache/polaris/pull/2765#discussion_r2408968369
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergRestCatalogEventServiceDelegator.java:
##########
@@ -275,7 +275,8 @@ public Response loadTable(
realmContext,
securityContext);
polarisEventListener.onAfterLoadTable(
- new AfterLoadTableEvent(catalogName, namespaceObj, (LoadTableResponse)
resp.getEntity()));
+ new AfterLoadTableEvent(
+ catalogName, namespaceObj, table, (LoadTableResponse)
resp.getEntity()));
Review Comment:
In general I feel this highlights a problem with the newly-refactored events
API -- there seems to be an assumption that the event content will always be
accessible through the response, which really may not be the case.
Indeed, if all the event's information can be derived from the
request/response pairs, why not just pass the request/response pairs in to the
listener? Why have event types at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
