dimas-b commented on code in PR #2674:
URL: https://github.com/apache/polaris/pull/2674#discussion_r2377349626
##########
CHANGELOG.md:
##########
@@ -107,7 +107,10 @@ Apache Polaris 1.1.0-incubating was released on September
19th, 2025.
ON CONFLICT (version_key) DO UPDATE
SET version_value = EXCLUDED.version_value;
COMMENT ON TABLE version IS 'the version of the JDBC schema in use';
+
+ ALTER TABLE polaris_schema.entities ADD COLUMN IF NOT EXISTS
location_without_scheme TEXT;
```
+ - Please don't enable
[OPTIMIZED_SIBLING_CHECK](https://github.com/apache/polaris/blob/740993963cb41c2c1b4638be5e04dd00f1263c98/polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java#L346)
feature configuration, once the above SQL statements are run. As it may lead
to incorrect behavior.
Review Comment:
This means that `OPTIMIZED_SIBLING_CHECK` must be `false` if the Polaris
data in the database came from an older version. `Once` in the comment above
makes the impression that it is somehow "caused" by running the `ALTER`
statement, while in fact the real reason is that data is missing because older
servers did not store it.
Could you clarity the note, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
