travis-bowen commented on code in PR #2767:
URL: https://github.com/apache/polaris/pull/2767#discussion_r2414876248
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java:
##########
@@ -774,33 +775,63 @@ public void authorizeOrThrow(
@Nonnull PolarisAuthorizableOperation authzOp,
@Nullable List<PolarisResolvedPathWrapper> targets,
@Nullable List<PolarisResolvedPathWrapper> secondaries) {
+ authorizeOrThrow(
+ polarisPrincipal, activatedEntities, EnumSet.of(authzOp), targets,
secondaries);
+ }
+
+ @Override
+ public void authorizeOrThrow(
+ @Nonnull PolarisPrincipal polarisPrincipal,
+ @Nonnull Set<PolarisBaseEntity> activatedEntities,
+ @Nonnull Set<PolarisAuthorizableOperation> authzOps,
+ @Nullable PolarisResolvedPathWrapper target,
+ @Nullable PolarisResolvedPathWrapper secondary) {
+ authorizeOrThrow(
Review Comment:
Honestly this and the other authorizeOrThrow (with single op and single
target / secondary) would probably be nice to have a default as well to default
to calling the option with a list of targets and secondaries.
The Polaris impls end up just delegating these other impls often do as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
