HonahX commented on code in PR #2523:
URL: https://github.com/apache/polaris/pull/2523#discussion_r2372540159
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -107,7 +109,7 @@ public static CatalogEntity fromCatalog(RealmConfig
realmConfig, Catalog catalog
return builder.build();
}
- public Catalog asCatalog() {
+ public Catalog asCatalog(ServiceIdentityRegistry serviceIdentityRegistry) {
Map<String, String> internalProperties = getInternalPropertiesAsMap();
Review Comment:
IIUC, `serviceIdentityRegistry` is only needed for `EXTERNAL` catalog and
more specifically the federation one. But this addition may imply that
`serviceIdentityRegistry` is required for all catalog, especially during the
conversion. Could we have both
```
public Catalog asCatalog()
...
public Catalog asCatalog(ServiceIdentityRegistry serviceIdentityRegistry)
...
```
and add some precondition to the first one that the serviceIdentityRegistry
is required in certain case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
