flyrain commented on code in PR #2797:
URL: https://github.com/apache/polaris/pull/2797#discussion_r2424944848
##########
regtests/README.md:
##########
@@ -187,19 +187,25 @@ Python tests are based on `pytest`. They rely on a python
Polaris client, which
The client can be generated using two commands:
```shell
-# generate the management api client
+# Management client
docker run --rm \
- -v ${PWD}:/local openapitools/openapi-generator-cli generate \
+ -v ${PWD}:/local openapitools/openapi-generator-cli:v7.9.0 generate \
-i /local/spec/polaris-management-service.yml \
-g python \
- -o /local/client/python
--additional-properties=packageName=polaris.management
--additional-properties=apiNamePrefix=polaris
+ -o /local/client/python \
+ --additional-properties=packageName=polaris.management \
+ --additional-properties=apiNamePrefix=polaris
-# generate the iceberg rest client
+# IRC client
Review Comment:
Same here
##########
regtests/README.md:
##########
@@ -187,19 +187,25 @@ Python tests are based on `pytest`. They rely on a python
Polaris client, which
The client can be generated using two commands:
```shell
-# generate the management api client
+# Management client
Review Comment:
minor: Is the original comment is more descriptive?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
