XJDKC commented on code in PR #2523:
URL: https://github.com/apache/polaris/pull/2523#discussion_r2402413008
##########
polaris-core/src/main/java/org/apache/polaris/core/entity/CatalogEntity.java:
##########
@@ -108,6 +110,10 @@ public static CatalogEntity fromCatalog(RealmConfig
realmConfig, Catalog catalog
}
public Catalog asCatalog() {
Review Comment:
Per @HonahX’s feedback, we can keep it for now so that in our tests or in
call sites that don’t need `ServiceIdentityProvider`, this method is still
usable and simple. I added a check for the catalog entity that is a
pass-through facade (federated catalog)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
