HonahX commented on code in PR #2731:
URL: https://github.com/apache/polaris/pull/2731#discussion_r2393158735
##########
spec/iceberg-rest-catalog-open-api.yaml:
##########
@@ -260,7 +260,6 @@ paths:
parameters:
- $ref: '#/components/parameters/page-token'
- $ref: '#/components/parameters/page-size'
- - $ref: '#/components/parameters/prefix'
Review Comment:
I remembered we once manually added this because there is a bug in python
api generator:
https://github.com/apache/polaris/pull/1347/files/4018286036aacd699cf7ed081bf98d19237486f5#r2079036380
Seems we do not need these anymore : )
##########
spec/iceberg-rest-catalog-open-api.yaml:
##########
@@ -429,6 +428,15 @@ paths:
examples:
NoSuchNamespaceExample:
$ref: '#/components/examples/NoSuchNamespaceError'
+ 409:
Review Comment:
We will need to update our exception mapper to be consistent with this:
https://github.com/apache/polaris/blob/ea50fe351f19b177460a713cfb524b96d94aba2b/runtime/service/src/main/java/org/apache/polaris/service/exception/IcebergExceptionMapper.java#L184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
