dimas-b commented on code in PR #2704:
URL: https://github.com/apache/polaris/pull/2704#discussion_r2389596834
##########
runtime/server/build.gradle.kts:
##########
@@ -44,6 +44,8 @@ dependencies {
runtimeOnly("org.postgresql:postgresql")
runtimeOnly(project(":polaris-relational-jdbc"))
runtimeOnly("io.quarkus:quarkus-jdbc-postgresql")
+ implementation(libs.mysql.connector.j)
Review Comment:
Everything _except_ the driver is acceptable, I think.
So, @Jayden-Chiu : you may want to keep the java code changes, but remove
the driver dependency. That would be mergeable from my POV (pending reviews
from other maintainers, of course). Then, instructions on bundling MySQL
Connector in a local build could be much simpler.
If the instructed for downstream builds with MySQL were added to a README or
docs, that would make a well-rounded PR, from my POV.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
