dimas-b commented on code in PR #2852:
URL: https://github.com/apache/polaris/pull/2852#discussion_r2449902880
##########
runtime/service/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java:
##########
@@ -52,15 +50,14 @@
@Identifier("default")
public class DefaultFileIOFactory implements FileIOFactory {
- private final StorageCredentialCache storageCredentialCache;
private final MetaStoreManagerFactory metaStoreManagerFactory;
+ private final AccessConfigProvider accessConfigProvider;
@Inject
public DefaultFileIOFactory(
- StorageCredentialCache storageCredentialCache,
- MetaStoreManagerFactory metaStoreManagerFactory) {
- this.storageCredentialCache = storageCredentialCache;
+ MetaStoreManagerFactory metaStoreManagerFactory, AccessConfigProvider
accessConfigProvider) {
this.metaStoreManagerFactory = metaStoreManagerFactory;
Review Comment:
Is `metaStoreManagerFactory` still required in this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
