adutra commented on code in PR #2757:
URL: https://github.com/apache/polaris/pull/2757#discussion_r2452660201
##########
helm/polaris/values.yaml:
##########
@@ -518,6 +516,16 @@ realmContext:
realms:
- POLARIS
+# -- Configuration for correlation IDs.
+correlationId:
Review Comment:
Hmm I'm not sure I fully understand your example. I'd imagine that, if some
event listener wants to send the event to a remote system and propagate OTel
context, it would leverage the OTel SDK and do something like this:
```java
@Inject Tracer tracer;
void processEvent(PolarisEvent event) {
var span = tracer.spanBuilder("polaris event
delivery").setSpanKind(SpanKind.PRODUCER).startSpan();
try (Scope scope = span.makeCurrent()) {
sendEventToMessageQueue(event);
}
}
```
The created span would have the current request span as its parent, then the
OTel magic would kick in when the appropriate propagator is invoked.
We might not even have to do this btw, some message queue clients probably
already add a PRODUCER span transparently whenever they produce a record to the
message broker.
The `CONSUMER` span kind would have to be created on the receiving side (the
message broker) for this to work, but I bet this is the case for most popular
message queues as they have the required instrumentation already.
Would that example solve your problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
