sungwy commented on PR #2680:
URL: https://github.com/apache/polaris/pull/2680#issuecomment-3443308613

   > For integration-tests, I'm thinking of having non-Quarkus integration 
tests against an OPA testcontainer in the "main" OPA module.
   > 
   > I've prepared some stuff for tests in [this 
commit](https://github.com/snazy/polaris/commit/0e535440eb9fa5cab6da4c7e25610f1b63505989)
 ([here](https://github.com/sungwy/polaris/pull/2) as well):
   > 
   > * Add a starter for an integration test in the "main" module
   > * Updated the existing int tests
   > 
   > Idea is to have the majority of integration-tests in the "main" module and 
only a smoke-test in runtime-service.
   > 
   > I think we can then get rid of the opa-tests module and can move the 
"main" module one directory level up.
   
   Thanks again @snazy :) Let me take a look at your draft PR and see if I can 
get rid of the `test` module and bring `impl` back up to `main`. I had some 
trouble achieving this because of the dependency on `:polaris-runtime-service`.
   
   Just so I'm clear: is your suggestion to move the QuarkusIntegrationTest 
annotated tests back into `polaris-runtime-service`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to