CodingBangboo commented on code in PR #2883:
URL: https://github.com/apache/polaris/pull/2883#discussion_r2462327666
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/dao/entity/ScopedCredentialsResult.java:
##########
@@ -37,20 +37,20 @@ public class ScopedCredentialsResult extends BaseResult {
public ScopedCredentialsResult(
@Nonnull ReturnStatus errorCode, @Nullable String extraInformation) {
super(errorCode, extraInformation);
- this.accessConfig = null;
+ this.storageAccessConfig = null;
}
/**
* Constructor for success
*
- * @param accessConfig credentials
+ * @param storageAccessConfig credentials
Review Comment:
Good point. I think we can keep it there for consistency with the javadoc in
other `BaseResult` classes. I also added a tiny bit to indicate that it is the
result from a successful `getSubscopedCredsForEntity()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
