adutra commented on code in PR #2939: URL: https://github.com/apache/polaris/pull/2939#discussion_r2478056613
########## helm/polaris/README.md: ########## @@ -60,10 +62,24 @@ eval $(minikube docker-env) -Dquarkus.container-image.build=true ``` +Otherwise load ready images from Docker Hub: +```bash +minikube image pull apache/polaris:latest +minikube image pull apache/polaris-admin-tool:latest +``` + ### Installing the chart locally The below instructions assume a local Kubernetes cluster is running and Helm is installed. +> [!NOTE] +> The exampled below assume that you have cloned Polaris git repository, which contains Helm chart in `helm/polaris` directory. Review Comment: ```suggestion > The examples below assume that you have cloned Polaris git repository, which contains the Polaris Helm chart in the `helm/polaris` directory. ``` ########## helm/polaris/README.md: ########## @@ -167,8 +190,12 @@ the Polaris repo root: helm unittest helm/polaris ``` -You can also lint the chart using the Chart Testing tool, with the following command: +You can also lint the chart using the Chart Testing tool. You will need to install the [yamllint](https://github.com/adrienverge/yamllint) tool: +```bash +brew install yamllint Review Comment: Shouldn't we show how to install `ct` as well? ########## helm/polaris/README.md: ########## @@ -60,10 +62,24 @@ eval $(minikube docker-env) -Dquarkus.container-image.build=true ``` +Otherwise load ready images from Docker Hub: +```bash +minikube image pull apache/polaris:latest +minikube image pull apache/polaris-admin-tool:latest +``` + ### Installing the chart locally The below instructions assume a local Kubernetes cluster is running and Helm is installed. +> [!NOTE] +> The exampled below assume that you have cloned Polaris git repository, which contains Helm chart in `helm/polaris` directory. +> If you do not want to clone the repository or want to use official release of Helm chart, you can download it from [Apache Polaris Helm Chart repository](https://downloads.apache.org/incubator/polaris/helm-chart/): Review Comment: ```suggestion > If you do not want to clone the repository or want to use an official Helm chart release, you can download it from the [Apache Polaris Helm Chart repository](https://downloads.apache.org/incubator/polaris/helm-chart/): ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
