MonkeyCanCode commented on code in PR #2943: URL: https://github.com/apache/polaris/pull/2943#discussion_r2479048540
########## plugins/spark/v3.5/getting-started/notebooks/Dockerfile: ########## @@ -34,14 +34,13 @@ USER spark WORKDIR /home/spark COPY --chown=spark client /home/spark/client -COPY --chown=spark plugins/spark/v3.5/getting-started/notebooks/requirements.txt /tmp/notebook_requirements.txt COPY --chown=spark regtests/requirements.txt /tmp +COPY --chown=spark regtests/notebook_requirements.txt /tmp COPY --chown=spark plugins/spark/v3.5/spark/build/2.12/libs /home/spark/polaris_libs -SHELL ["/bin/bash", "-c"] RUN python3 -m venv /home/spark/venv && \ - source /home/spark/venv/bin/activate && \ + . /home/spark/venv/bin/activate && \ Review Comment: So `source` is only available if u have `SHELL ["/bin/bash", "-c"]`...this is to simplify that (we do this in couple place already in current repo) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
