fivetran-arunsuri commented on PR #2941:
URL: https://github.com/apache/polaris/pull/2941#issuecomment-3470428644
Thanks @adutra @dimas-b — I verified the Quarkus option works:
`quarkus.http.header."Server".value=Polaris/${quarkus.application.version}
`
I kept the ServerHeaderFilter behind polaris.http.version-header.enabled
(default false) based on the previous dev email discussion to have a true off
switch (fully removes the header, not just overrides). This addresses the
“can’t unset” concern you mentioned. I’ll also document the Quarkus property as
a downstream-friendly alternative for per-deployment control.
Unless there are objections, I’ll merge this as-is and add docs:
- how to enable via polaris.http.version-header.enabled=true
- how downstreams can set the Quarkus property instead if they prefer
config-only.
If you’d rather we switch to config-only now, happy to do that, but I think
this strikes a good balance (explicit toggle + simple override path).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
