singhpk234 commented on code in PR #2887:
URL: https://github.com/apache/polaris/pull/2887#discussion_r2483194389
##########
runtime/service/src/main/java/org/apache/polaris/service/reporting/DefaultMetricsReporter.java:
##########
@@ -0,0 +1,19 @@
+package org.apache.polaris.service.reporting;
+
+import io.smallrye.common.annotation.Identifier;
+import jakarta.enterprise.context.RequestScoped;
+import org.apache.iceberg.rest.requests.ReportMetricsRequest;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@RequestScoped
+@Identifier("default")
+public class DefaultMetricsReporter implements MetricsReporter {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(DefaultMetricsReporter.class);
+
+ @Override
+ public void reportMetric(
+ String prefix, String namespace, String table, ReportMetricsRequest
reportMetricsRequest) {
+ // Do Nothing
Review Comment:
Agree, though It can be any persistence, not necessarily an OLTP imho an
OLAP is a valid consideration too, so is dumping in object storge so analytical
engines can make a table on top of from Polaris POV, it seems to me that we are
settling on catalog name and tble identifiers in addition to report from
interface POV, why is realm-id not part of it is my doubt, why is authenticate
prinicipals not part of these metric ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
