ajantha-bhat commented on code in PR #36:
URL: https://github.com/apache/polaris-tools/pull/36#discussion_r2486994907
##########
iceberg-catalog-migrator/gradle/libs.versions.toml:
##########
@@ -62,8 +62,15 @@ google-java-format = { module =
"com.google.googlejavaformat:google-java-format"
guava = { module = "com.google.guava:guava", version.ref = "guava" }
hadoop-aws = { module = "org.apache.hadoop:hadoop-aws", version.ref = "hadoop"
}
hadoop-common = { module = "org.apache.hadoop:hadoop-common", version.ref =
"hadoop" }
+iceberg-api = { module = "org.apache.iceberg:iceberg-api", version.ref =
"iceberg" }
+iceberg-aws = { module = "org.apache.iceberg:iceberg-aws", version.ref =
"iceberg" }
+iceberg-azure = { module = "org.apache.iceberg:iceberg-azure", version.ref =
"iceberg" }
+iceberg-common = { module = "org.apache.iceberg:iceberg-common", version.ref =
"iceberg" }
+iceberg-core = { module = "org.apache.iceberg:iceberg-core", version.ref =
"iceberg" }
iceberg-dell = { module = "org.apache.iceberg:iceberg-dell", version.ref =
"iceberg" }
-iceberg-spark-runtime = { module =
"org.apache.iceberg:iceberg-spark-runtime-3.5_2.12", version.ref = "iceberg" }
+iceberg-gcp = { module = "org.apache.iceberg:iceberg-gcp", version.ref =
"iceberg" }
+iceberg-hive-metastore = { module =
"org.apache.iceberg:iceberg-hive-metastore", version.ref = "iceberg" }
+iceberg-nessie = { module = "org.apache.iceberg:iceberg-nessie", version.ref =
"iceberg" }
Review Comment:
ACK.
Thanks and I created a separate PR for cleanup up dependencies and handled
your `bom` suggestion too.
https://github.com/apache/polaris-tools/pull/38
I will rebase this PR. Once it is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
