dimas-b commented on code in PR #2911:
URL: https://github.com/apache/polaris/pull/2911#discussion_r2487520421
##########
build-logic/src/main/kotlin/publishing/configurePom.kt:
##########
@@ -85,7 +86,14 @@ internal fun configurePom(project: Project,
mavenPublication: MavenPublication,
licenses {
license {
name.set("Apache-2.0") // SPDX identifier
- url.set(asfProject.licenseUrl)
+ url.set(gitInfo.rawGithubLink("LICENSE"))
+ comments.set(
+ """
+ NOTICE: ${gitInfo.rawGithubLink("NOTICE")}
+ DISCLAIMER: ${gitInfo.rawGithubLink("DISCLAIMER")}
Review Comment:
Adding these links for release builds sounds valuable to me, but given
current impl. of `GitInfo` for non-release builds (using `HEAD`) I do not think
the links would be useful or even correct.
Could we identity whether `GetInfo` has a solid tag and avoid adding links
if it does not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
