MonkeyCanCode commented on code in PR #2957:
URL: https://github.com/apache/polaris/pull/2957#discussion_r2488317096
##########
plugins/spark/v3.5/regtests/Dockerfile:
##########
@@ -18,31 +18,29 @@
#
FROM docker.io/apache/spark:3.5.6-java17
-ARG POLARIS_HOST=polaris
-ENV POLARIS_HOST=$POLARIS_HOST
-ENV SPARK_HOME=/opt/spark
-ENV CURRENT_SCALA_VERSION='2.12'
-ENV LANGUAGE='en_US:en'
+
+ARG POLARIS_HOST=polaris \
+ CURRENT_SCALA_VERSION=2.12
Review Comment:
And for reference, `plugins/spark/v3.5/regtests/run.sh` use this. However,
this is not needed for
`plugins/spark/v3.5/getting-started/notebooks/Dockerfile`, thus, I removed it
from there.
##########
plugins/spark/v3.5/getting-started/notebooks/Dockerfile:
##########
@@ -19,8 +19,10 @@
FROM docker.io/apache/spark:3.5.6-java17
-ENV
PYTHONPATH="${SPARK_HOME}/python/:${SPARK_HOME}/python/lib/py4j-0.10.9.7-src.zip:/home/spark/venv/lib/python3.10/site-packages"
-ENV PYSPARK_PYTHON=/home/spark/venv/bin/python
+ARG CURRENT_SCALA_VERSION=2.12
Review Comment:
Discussed on the other comment. This will be removed for now.
##########
site/docker/Dockerfile:
##########
@@ -21,23 +21,14 @@ FROM ubuntu:24.04 AS hugo
ENV LANGUAGE='en_US:en'
-RUN apt-get update
-RUN apt-get install --yes golang hugo asciidoctor npm curl
-RUN apt-get clean
-# http-server is used when building the static site to manually check it
locally
-# (via `site/bin/create-static-site.sh --local` at http://localhost:8080/)
-RUN npm install --global http-server
-
-# these dependencies are needed to build the static site
-#RUN npm install --global autoprefixer postcss postcss-cli http-server
-
-RUN mkdir /polaris
-RUN mkdir /polaris/site
-RUN mkdir /polaris/site/resources
+RUN apt-get update && \
+ apt-get install -y --no-install-recommends golang hugo asciidoctor npm
curl git && \
Review Comment:
Here is the error I was referring to when `git` was not installed:
```
[+] Running 6/6
✔ polaris_site-hugo Built
0.0s
✔ Network polaris_site_default Created
0.0s
✔ Volume polaris_site_workspace Created
0.0s
✔ Volume polaris_site_resources Created
0.0s
✔ Volume polaris_site_hugo_cache Created
0.0s
✔ Container polaris_site-hugo-1 Created
0.0s
Attaching to hugo-1
hugo-1 | go: github.com/google/[email protected]: git init --bare in
/hugo/cache/modules/filecache/modules/pkg/mod/cache/vcs/98f59a39bbbc2d4de9185a32a3d8790111161ae9778e3e5e32a90c95f026ac9b:
exec: "git": executable file not found in $PATH
...
hugo-1 | Error: command error: failed to load modules: failed to download
modules: failed to execute 'go [mod download -modcacherw]': failed to execute
binary "go" with args [mod download -modcacherw]: go:
github.com/google/[email protected]: git init --bare in
/hugo/cache/modules/filecache/modules/pkg/mod/cache/vcs/98f59a39bbbc2d4de9185a32a3d8790111161ae9778e3e5e32a90c95f026ac9b:
exec: "git": executable file not found in $PATH
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
