vchag commented on code in PR #2962: URL: https://github.com/apache/polaris/pull/2962#discussion_r2493134104
########## runtime/service/src/main/java/org/apache/polaris/service/events/listeners/AllEventsForwardingListener.java: ########## @@ -0,0 +1,854 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.polaris.service.events.listeners; + +import org.apache.polaris.service.events.AfterAttemptTaskEvent; +import org.apache.polaris.service.events.BeforeAttemptTaskEvent; +import org.apache.polaris.service.events.BeforeLimitRequestRateEvent; +import org.apache.polaris.service.events.CatalogGenericTableServiceEvents; +import org.apache.polaris.service.events.CatalogPolicyServiceEvents; +import org.apache.polaris.service.events.CatalogsServiceEvents; +import org.apache.polaris.service.events.IcebergRestCatalogEvents; +import org.apache.polaris.service.events.PolarisEvent; +import org.apache.polaris.service.events.PrincipalRolesServiceEvents; +import org.apache.polaris.service.events.PrincipalsServiceEvents; + +/** + * Base class for event listeners that with to generically forward all {@link PolarisEvent + * PolarisEvents} to an external sink. + * + * <p>This design follows the Template Method pattern, centralizing shared control flow in the base + * class while allowing subclasses to supply the event-specific behavior. + */ +public abstract class AllEventsForwardingListener implements PolarisEventListener { + + /** Subclasses implement the actual logic once, generically. */ + protected abstract void handle(PolarisEvent event); + + /** Optional filter (config-based). Default: handle all. */ + protected boolean shouldHandle(Object event) { Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
