snazy commented on code in PR #3022:
URL: https://github.com/apache/polaris/pull/3022#discussion_r2514450716
##########
getting-started/ceph/docker-compose.yml:
##########
@@ -31,18 +32,18 @@ services:
- >-
set -ex;
mkdir -p /var/lib/ceph/osd/ceph-0;
- ceph-authtool --create-keyring /tmp/ceph.mon.keyring --gen-key -n mon.
--cap mon 'allow *';
+ ceph-authtool --create-keyring /var/lib/ceph/tmp/ceph.mon.keyring
--gen-key -n mon. --cap mon 'allow *';
ceph-authtool --create-keyring /etc/ceph/ceph.client.admin.keyring \
--gen-key -n client.admin \
--cap mon 'allow *' --cap osd 'allow *' --cap mgr 'allow *' --cap
mds 'allow *';
ceph-authtool --create-keyring
/var/lib/ceph/bootstrap-osd/ceph.keyring \
--gen-key -n client.bootstrap-osd \
--cap mon 'profile bootstrap-osd' --cap mgr 'allow r';
- ceph-authtool /tmp/ceph.mon.keyring --import-keyring
/etc/ceph/ceph.client.admin.keyring;
- ceph-authtool /tmp/ceph.mon.keyring --import-keyring
/var/lib/ceph/bootstrap-osd/ceph.keyring;
- chown ceph:ceph /tmp/ceph.mon.keyring;
- monmaptool --create --add mon1 ${MON_IP} --fsid ${FSID} /tmp/monmap
--clobber;
- sudo -u ceph ceph-mon --mkfs -i mon1 --monmap /tmp/monmap --keyring
/tmp/ceph.mon.keyring;
+ ceph-authtool /var/lib/ceph/tmp/ceph.mon.keyring --import-keyring
/etc/ceph/ceph.client.admin.keyring;
+ ceph-authtool /var/lib/ceph/tmp/ceph.mon.keyring --import-keyring
/var/lib/ceph/bootstrap-osd/ceph.keyring;
+ chown ceph:ceph /var/lib/ceph/tmp/ceph.mon.keyring;
+ monmaptool --create --add mon1 ${MON_IP} --fsid ${FSID}
/var/lib/ceph/tmp/monmap --clobber;
+ sudo -u ceph ceph-mon --mkfs -i mon1 --monmap /var/lib/ceph/tmp/monmap
--keyring /var/lib/ceph/tmp/ceph.mon.keyring;
Review Comment:
This `sudo` is what Podman complains about
##########
getting-started/ceph/README.md:
##########
@@ -47,24 +42,38 @@ The services are started **in sequence**:
Note: this example pulls the `apache/polaris:latest` image, but assumes the
image is `1.2.0-incubating` or later.
+### 1. Copy the example environment file
+```shell
+cp getting-started/ceph/.env.example getting-started/ceph/.env
+```
+
+### 2. Prepare Network
+```shell
+# Optional: force runtime (docker or podman)
+export RUNTIME=docker
Review Comment:
Don't really need this. Podman has a CLI compatibility package, so people
can run Podman via the `docker` executable name.
##########
getting-started/ceph/README.md:
##########
@@ -47,24 +42,38 @@ The services are started **in sequence**:
Note: this example pulls the `apache/polaris:latest` image, but assumes the
image is `1.2.0-incubating` or later.
+### 1. Copy the example environment file
+```shell
+cp getting-started/ceph/.env.example getting-started/ceph/.env
Review Comment:
```suggestion
cp .env.example .env
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
