adnanhemani commented on code in PR #2998:
URL: https://github.com/apache/polaris/pull/2998#discussion_r2520872724
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisCatalogsEventServiceDelegator.java:
##########
@@ -51,37 +53,50 @@ public class PolarisCatalogsEventServiceDelegator
implements PolarisCatalogsApiS
@Inject @Delegate PolarisCatalogsApiService delegate;
@Inject PolarisEventListener polarisEventListener;
+ @Inject PolarisEventMetadataFactory eventMetadataFactory;
@Override
public Response createCatalog(
CreateCatalogRequest request, RealmContext realmContext, SecurityContext
securityContext) {
polarisEventListener.onBeforeCreateCatalog(
- new
CatalogsServiceEvents.BeforeCreateCatalogEvent(request.getCatalog().getName()));
+ new CatalogsServiceEvents.BeforeCreateCatalogEvent(
+ PolarisEvent.createEventId(),
Review Comment:
I understand your point, it is definitely a bit of a "grey area." I think
the amount of cleanliness that we gain from moving it into EventMetadata
outweighs the ambiguities here, though. I'm also willing to sway my opinion
with the will of the community, but I would vote for merging it into
EventMetadata if others feel similarly :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
