adnanhemani opened a new pull request, #3073: URL: https://github.com/apache/polaris/pull/3073
<!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> This PR introduces a new event type `StageCommitTableEvent`, which triggers only in the case of a transactional commit at the time the staged commit is generated (before the commit is actually applied). This allows us to reserve the `AfterCommitTableEvent` solely for when the commit has been successfully applied. In order to do this, I've made a slight addition to the `TransactionWorkspaceMetaStoreManager` class to add the staging of events, mirroring exactly how we stage updates. Noting that there is no unit testing for this class, I've added this as well. Additionally, E2E testing for the events emissions in the CommitTransaction API has been added, looking both at the happy and sad paths. ## Checklist - [X] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [X] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes #2990. - [X] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [X] ๐ก Added comments for complex logic - [N/A] ๐งพ Updated `CHANGELOG.md` (if needed) - [N/A] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) Closes #2990. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
