snazy commented on code in PR #2383:
URL: https://github.com/apache/polaris/pull/2383#discussion_r2537961378
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -257,6 +257,12 @@ jobs:
distribution: 'temurin'
java-version: '21'
+ - name: Set up QEMU
+ uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392
+
+ - name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v3
Review Comment:
(same for the 4th workflow)
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -257,6 +257,12 @@ jobs:
distribution: 'temurin'
java-version: '21'
+ - name: Set up QEMU
+ uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392
+
+ - name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v3
Review Comment:
I guess all that's needed is [this
part](https://github.com/snazy/maxio-daily/blob/e717a87525e4d2ebe2e71245d6b2ed1cf386f5bc/src/buildx.sh#L29-L35),
potentially adapted?
[This
line](https://github.com/snazy/maxio-daily/blob/e717a87525e4d2ebe2e71245d6b2ed1cf386f5bc/src/buildx.sh#L39)
might help w/ debugging.
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -193,7 +193,7 @@ jobs:
source "${LIBS_DIR}/_exec.sh"
# Publish artifacts to staging repository
- exec_process ./gradlew publishToApache closeApacheStagingRepository
-Prelease -PuseGpgAgent --info > gradle_publish_output.txt 2>&1
+ exec_process ./gradlew publishToApache closeApacheStagingRepository
-Prelease -PuseGpgAgent --info 2>&1 | tee gradle_publish_output.txt
Review Comment:
Just FYI (no change needed/requested): an even shorter version of `2>&1` is
`&>` (see
[here](https://www.gnu.org/software/bash/manual/html_node/Redirections.html#Redirecting-Standard-Output-and-Standard-Error)).
I recently learned that as well.
##########
.github/workflows/release-3-build-and-publish-artifacts.yml:
##########
@@ -257,6 +257,12 @@ jobs:
distribution: 'temurin'
java-version: '21'
+ - name: Set up QEMU
+ uses: docker/setup-qemu-action@29109295f81e9208d7d86ff1c6c12d2833863392
+
+ - name: Set up Docker Buildx
+ uses: docker/setup-buildx-action@v3
Review Comment:
Not an [approved
action](https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml).
It it really needed? IIRC buildx is [already
installed](https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#tools).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
