singhpk234 commented on code in PR #2280: URL: https://github.com/apache/polaris/pull/2280#discussion_r2544211734
########## runtime/service/src/main/java/org/apache/polaris/service/storage/s3/sign/S3RemoteSigningCatalogHandler.java: ########## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.storage.s3.sign; + +import java.util.Collection; +import java.util.EnumSet; +import java.util.Optional; +import java.util.Set; +import org.apache.iceberg.BaseTable; +import org.apache.iceberg.Table; +import org.apache.iceberg.catalog.Catalog; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.ForbiddenException; +import org.apache.polaris.core.PolarisDiagnostics; +import org.apache.polaris.core.auth.PolarisAuthorizableOperation; +import org.apache.polaris.core.auth.PolarisAuthorizer; +import org.apache.polaris.core.auth.PolarisPrincipal; +import org.apache.polaris.core.config.FeatureConfiguration; +import org.apache.polaris.core.config.RealmConfig; +import org.apache.polaris.core.context.CallContext; +import org.apache.polaris.core.entity.CatalogEntity; +import org.apache.polaris.core.entity.PolarisEntity; +import org.apache.polaris.core.entity.PolarisEntityConstants; +import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper; +import org.apache.polaris.core.persistence.resolver.ResolutionManifestFactory; +import org.apache.polaris.core.storage.InMemoryStorageIntegration; +import org.apache.polaris.core.storage.PolarisStorageActions; +import org.apache.polaris.core.storage.PolarisStorageConfigurationInfo; +import org.apache.polaris.core.storage.StorageUtil; +import org.apache.polaris.service.catalog.common.CatalogHandler; +import org.apache.polaris.service.catalog.common.CatalogUtils; +import org.apache.polaris.service.catalog.io.FileIOUtil; +import org.apache.polaris.service.context.catalog.CallContextCatalogFactory; +import org.apache.polaris.service.s3.sign.model.PolarisS3SignRequest; +import org.apache.polaris.service.s3.sign.model.PolarisS3SignResponse; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class S3RemoteSigningCatalogHandler extends CatalogHandler implements AutoCloseable { + + private static final Logger LOGGER = LoggerFactory.getLogger(S3RemoteSigningCatalogHandler.class); + + private final CallContextCatalogFactory catalogFactory; + private final S3RequestSigner s3RequestSigner; + + private CatalogEntity catalogEntity; + private Catalog baseCatalog; + + public S3RemoteSigningCatalogHandler( + PolarisDiagnostics diagnostics, + CallContext callContext, + ResolutionManifestFactory resolutionManifestFactory, + CallContextCatalogFactory catalogFactory, + PolarisPrincipal polarisPrincipal, + String catalogName, + PolarisAuthorizer authorizer, + S3RequestSigner s3RequestSigner) { + super( + diagnostics, + callContext, + resolutionManifestFactory, + polarisPrincipal, + catalogName, + authorizer, + // external catalogs are not supported for S3 remote signing + null, + null); + this.catalogFactory = catalogFactory; + this.s3RequestSigner = s3RequestSigner; + } + + @Override + protected void initializeCatalog() { + catalogEntity = + CatalogEntity.of(resolutionManifest.getResolvedReferenceCatalogEntity().getRawLeafEntity()); + if (catalogEntity.isExternal()) { + throw new ForbiddenException("Cannot use S3 remote signing with federated catalogs."); + } + baseCatalog = + catalogFactory.createCallContextCatalog(callContext, polarisPrincipal, resolutionManifest); + } + + public PolarisS3SignResponse signS3Request( + PolarisS3SignRequest s3SignRequest, TableIdentifier tableIdentifier) { + + LOGGER.debug("Requesting s3 signing for {}: {}", tableIdentifier, s3SignRequest); + + PolarisAuthorizableOperation authzOp = + s3SignRequest.write() + ? PolarisAuthorizableOperation.SIGN_S3_WRITE_REQUEST + : PolarisAuthorizableOperation.SIGN_S3_READ_REQUEST; + + authorizeRemoteSigningOrThrow(EnumSet.of(authzOp), tableIdentifier); + + // Must be done after the authorization check, as the auth check creates the catalog entity + throwIfRemoteSigningNotEnabled(callContext.getRealmConfig(), catalogEntity); + + var result = + InMemoryStorageIntegration.validateAllowedLocations( + callContext.getRealmConfig(), + getAllowedLocations(tableIdentifier), + getStorageActions(s3SignRequest), + getTargetLocations(s3SignRequest)); + + if (result.values().stream().anyMatch(r -> r.values().stream().anyMatch(v -> !v.isSuccess()))) { + throw new ForbiddenException("Requested S3 location is not allowed."); + } + + PolarisS3SignResponse s3SignResponse = s3RequestSigner.signRequest(s3SignRequest); + LOGGER.debug("S3 signing response: {}", s3SignResponse); + + return s3SignResponse; + } + + private Collection<String> getAllowedLocations(TableIdentifier tableIdentifier) { + + if (baseCatalog.tableExists(tableIdentifier)) { + + // If the table exists, get allowed locations from the table metadata + Table table = baseCatalog.loadTable(tableIdentifier); Review Comment: iceberg properties location, write.data.path, write.metadata.path, which is used for credential vending, I am not sure we persist them Entity, as the function StorageUtil#getLocationsUsedByTable has always worked in TableMetadata and not on Entity properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
