pingtimeout commented on code in PR #3116:
URL: https://github.com/apache/polaris/pull/3116#discussion_r2555518467
##########
releasey/libs/_github.sh:
##########
@@ -43,7 +43,7 @@ function check_github_checks_passed() {
local repo_info="$GITHUB_REPOSITORY"
local num_invalid_checks
- local num_invalid_checks_retrieval_command="gh api
repos/${repo_info}/commits/${commit_sha}/check-runs --jq '[.check_runs[] |
select(.conclusion != \"success\" and .conclusion != \"skipped\" and (.name |
startswith(\"Release - \") | not))] | length'"
+ local num_invalid_checks_retrieval_command="gh api
repos/${repo_info}/commits/${commit_sha}/check-runs --jq '[.check_runs[] |
select(.conclusion != \"success\" and .conclusion != \"skipped\" and (.name |
startswith(\"Release - \") | not) and (.name != \"markdown-link-check\"))] |
length'"
Review Comment:
I want to run a full release cycle before merging this, and that requires
all CI checks to pass (>20 minutes) plus another 20 minutes to fully package
Polaris and its components. Let's open a separate PR for that so that I can
merge this PR and release 1.3.0 in about 45 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
