gh-yzou commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2557190949
##########
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java:
##########
@@ -71,7 +71,11 @@ public Table loadTable(Identifier identifier) throws
NoSuchTableException {
try {
GenericTable genericTable =
this.polarisCatalog.loadGenericTable(Spark3Util.identifierToTableIdentifier(identifier));
- return PolarisCatalogUtils.loadSparkTable(genericTable);
+ if (PolarisCatalogUtils.useHudi(genericTable.getFormat())) {
Review Comment:
can you add a comment here about why we are returning V1Table for Hudi, but
V2 table for rest? For example, "hudi doesn't support datasource v2 yet, and
therefore returns V1Table"
##########
plugins/spark/README.md:
##########
@@ -123,4 +123,4 @@ Following describes the current functionality limitations
of the Polaris Spark c
2) Create a Delta table without explicit location is not supported.
3) Rename a Delta table is not supported.
4) ALTER TABLE ... SET LOCATION is not supported for DELTA table.
-5) For other non-Iceberg tables like csv, it is not supported today.
+5) For other non-Iceberg tables like csv, it is not supported today.
Review Comment:
there seems no change, maybe revert this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
