adnanhemani commented on code in PR #3071: URL: https://github.com/apache/polaris/pull/3071#discussion_r2565974622
########## polaris-core/src/test/java/org/apache/polaris/service/storage/aws/AwsCredentialsStorageIntegrationTest.java: ########## Review Comment: Sorry, missed this comment (please feel free to ping on Slack if I forget again in the future!). I'm fine with merging as-is, I just find it odd to write tests (even if they are unit tests) with placeholder values that are clearly wrong - but I know you did not write this particular test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
