dimas-b commented on code in PR #3170:
URL: https://github.com/apache/polaris/pull/3170#discussion_r2566615076
##########
polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisCredential.java:
##########
@@ -31,14 +31,22 @@
public interface PolarisCredential extends Credential {
static PolarisCredential of(
- @Nullable Long principalId, @Nullable String principalName, Set<String>
principalRoles) {
+ @Nullable String token,
+ @Nullable Long principalId,
+ @Nullable String principalName,
+ Set<String> principalRoles) {
Review Comment:
Please add a new `of()` method for the new parameter (since it's optional).
This way existing code that does not use the token, does not have to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
