Copilot commented on code in PR #3188:
URL: https://github.com/apache/polaris/pull/3188#discussion_r2578407111
##########
runtime/spark-tests/build.gradle.kts:
##########
@@ -56,7 +64,7 @@ dependencies {
testImplementation(enforcedPlatform(libs.scala212.lang.library))
testImplementation(enforcedPlatform(libs.scala212.lang.reflect))
testImplementation(libs.javax.servlet.api)
- testImplementation(libs.antlr4.runtime)
+ // ANTLR version is determined by Spark/Delta dependencies, not enforced
Review Comment:
[nitpick] The comment in line 67 states the table was removed with
`testImplementation(libs.antlr4.runtime)`, but this removal is necessary
because the ANTLR version should be determined by Spark/Delta dependencies.
However, the comment on line 67 should mention that ANTLR 4.9.3 is being forced
in the configurations block (lines 26-32), which might cause confusion about
where the ANTLR version is actually controlled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
