adam-christian-software commented on code in PR #85: URL: https://github.com/apache/polaris-tools/pull/85#discussion_r2578490863
########## console/spec/bundled-polaris-catalog-service.yaml: ########## @@ -0,0 +1,4629 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +openapi: 3.0.3 Review Comment: I think that a copy & paste is fine for now, but eventually, I'd expect that we would have some way of pulling in the Polaris APIs from the Polaris instance. Same with the polaris-management-service spec as well. Do you have an idea on how we want to do that? It's OK if not. We can just file a Git issue. ########## console/package.json: ########## @@ -0,0 +1,58 @@ +{ + "name": "polaris-console", + "private": true, + "version": "1.3.0-incubating", + "type": "module", + "scripts": { Review Comment: I'm not seeing any unit tests or any way to test this yet. Can we file a Git issue, so we can handle this after merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
