cccs-cat001 commented on code in PR #3170:
URL: https://github.com/apache/polaris/pull/3170#discussion_r2588839871
##########
api/management-model/src/test/java/org/apache/polaris/core/admin/model/CatalogSerializationTest.java:
##########
@@ -72,6 +72,7 @@ public void testJsonFormat() throws JsonProcessingException {
+ "\"storageConfigInfo\":{"
+ "\"roleArn\":\"arn:aws:iam::123456789012:role/test-role\","
+ "\"allowedKmsKeys\":[],"
+ + "\"propagateApiUserIdentity\":false,"
Review Comment:
Okay so I've been banging my head against the wall with this for a little
bit. The only difference I can find between this and the `stsUnavailable` is
that we have `propagateApiUserIdentity` default to false, this was so that we
didn't get errors in `AwsCredentialsStorageIntegration.java L101`, but I've
since added the `Boolean.TRUE.equals` so I think it's fine to remove the
default in the `polaris-management-service.yml`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
