dimas-b commented on code in PR #3250:
URL: https://github.com/apache/polaris/pull/3250#discussion_r2608857758
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/resolver/Resolver.java:
##########
@@ -744,13 +745,42 @@ private ResolverStatus resolvePaths(
private ResolverStatus resolveCallerPrincipalAndPrincipalRoles(
List<ResolvedPolarisEntity> toValidate) {
+ if (isExternalPrincipal()) {
+ PrincipalEntity externalPrincipal = createExternalPrincipalEntity();
Review Comment:
Conceptually, IMHO, the principal _entity_ should only be required for AuthZ
checks (which do not actually require it if it's external). So, any
intermediate code that requires it may need to be refactored... but TBH, I do
not remember that code very well :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
