flyrain commented on code in PR #85: URL: https://github.com/apache/polaris-tools/pull/85#discussion_r2616608207
########## console/src/pages/Connections.tsx: ########## @@ -0,0 +1,368 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import { useState } from "react" +import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query" +import { toast } from "sonner" +import { formatDistanceToNow } from "date-fns" +import { Link as LinkIcon, Plus, RefreshCw, Search, MoreVertical } from "lucide-react" +import { principalsApi } from "@/api/management/principals" +import { getErrorMessage } from "@/lib/errorHandler" +import type { Principal } from "@/types/api" +import { Button } from "@/components/ui/button" +import { Input } from "@/components/ui/input" +import { Badge } from "@/components/ui/badge" +import { + Table, + TableBody, + TableCell, + TableHead, + TableHeader, + TableRow, +} from "@/components/ui/table" +import { + DropdownMenu, + DropdownMenuContent, + DropdownMenuItem, + DropdownMenuTrigger, +} from "@/components/ui/dropdown-menu" +import { + Dialog, + DialogContent, + DialogDescription, + DialogFooter, + DialogHeader, + DialogTitle, +} from "@/components/ui/dialog" +import { ConfigureConnectionModal } from "@/components/forms/ConfigureConnectionModal" +import { CredentialsModal } from "@/components/forms/CredentialsModal" +import { PrincipalDetailsModal } from "@/components/users/PrincipalDetailsModal" +import { EditPrincipalModal } from "@/components/forms/EditPrincipalModal" +import { ResetCredentialsModal } from "@/components/forms/ResetCredentialsModal" + +export function Connections() { + const [searchQuery, setSearchQuery] = useState("") + const [isConfigureModalOpen, setIsConfigureModalOpen] = useState(false) + const [isCredentialsModalOpen, setIsCredentialsModalOpen] = useState(false) + const [connectionToDelete, setConnectionToDelete] = useState<string | null>(null) + const [connectionToReset, setConnectionToReset] = useState<string | null>(null) + const [principalToView, setPrincipalToView] = useState<Principal | null>(null) + const [principalToEdit, setPrincipalToEdit] = useState<Principal | null>(null) + const [generatedCredentials, setGeneratedCredentials] = useState<{ + clientId: string + clientSecret: string + } | null>(null) + + const queryClient = useQueryClient() + + const { data: principals = [], isLoading } = useQuery({ + queryKey: ["principals"], + queryFn: () => principalsApi.list(), + }) + + const deleteMutation = useMutation({ + mutationFn: (principalName: string) => principalsApi.delete(principalName), + onSuccess: () => { + toast.success("Connection deleted successfully") + queryClient.invalidateQueries({ queryKey: ["principals"] }) + setConnectionToDelete(null) + }, + onError: (error: unknown) => { + const errorMsg = getErrorMessage( + error, + "Failed to delete connection", + "connection", + "delete" + ) + toast.error("Failed to delete connection", { + description: errorMsg, + }) + }, + }) + + const rotateMutation = useMutation({ + mutationFn: (principalName: string) => + principalsApi.rotateCredentials(principalName), + onSuccess: (data) => { + toast.success("Credentials rotated successfully") + setGeneratedCredentials({ + clientId: data.credentials.clientId, + clientSecret: data.credentials.clientSecret, + }) + setIsCredentialsModalOpen(true) + queryClient.invalidateQueries({ queryKey: ["principals"] }) + }, + onError: (error: unknown) => { + const errorMsg = getErrorMessage( + error, + "Failed to rotate credentials", + "credentials", + "rotate" + ) + toast.error("Failed to rotate credentials", { + description: errorMsg, + }) + }, + }) + + const handleResetSuccess = (credentials: { clientId: string; clientSecret: string }) => { + setGeneratedCredentials(credentials) + setIsCredentialsModalOpen(true) + queryClient.invalidateQueries({ queryKey: ["principals"] }) + setConnectionToReset(null) + } + + const filteredPrincipals = principals.filter((principal) => + principal.name.toLowerCase().includes(searchQuery.toLowerCase()) + ) + + + const handleCreateSuccess = (credentials: { clientId: string; clientSecret: string }) => { + setGeneratedCredentials(credentials) + setIsConfigureModalOpen(false) + setIsCredentialsModalOpen(true) + queryClient.invalidateQueries({ queryKey: ["principals"] }) + } + + return ( + <div className="p-8"> + {/* Header */} + <div className="mb-6"> + <div className="flex items-center justify-between"> + <div className="flex items-center gap-3"> + <LinkIcon className="h-6 w-6 text-foreground" /> + <h1 className="text-3xl font-bold text-foreground">Service Connections</h1> + </div> + <div className="flex items-center gap-3"> + <div className="flex items-center gap-2"> + <Input + placeholder="Q Search" + value={searchQuery} + onChange={(e) => setSearchQuery(e.target.value)} + className="w-48" + /> + <Button variant="ghost" size="icon"> + <Search className="h-4 w-4" /> + </Button> + </div> + <Button variant="ghost" size="icon" onClick={() => queryClient.invalidateQueries({ queryKey: ["principals"] })}> + <RefreshCw className="h-4 w-4" /> + </Button> + <Button + onClick={() => setIsConfigureModalOpen(true)} + variant="default" + > + <Plus className="mr-2 h-4 w-4" /> + Connection + </Button> + </div> + </div> + </div> + + {/* Table */} + <div className="rounded-lg border bg-card"> + <Table> + <TableHeader> + <TableRow> + <TableHead>PRINCIPAL NAME</TableHead> + <TableHead>SERVICE</TableHead> + <TableHead>CREATED</TableHead> + <TableHead className="w-[50px]"></TableHead> + </TableRow> + </TableHeader> + <TableBody> + {isLoading ? ( + <TableRow> + <TableCell colSpan={4} className="text-center py-8 text-muted-foreground"> + Loading... + </TableCell> + </TableRow> + ) : filteredPrincipals.length === 0 ? ( + <TableRow> + <TableCell colSpan={4} className="text-center py-8 text-muted-foreground"> + No connections found + </TableCell> + </TableRow> + ) : ( + filteredPrincipals.map((principal) => { + // Cast to include timestamp fields that may be present in API response + const principalWithTimestamps = principal as Principal & { + createTimestamp?: number + lastUpdateTimestamp?: number + } + // Try createTimestamp first, then lastUpdateTimestamp as fallback + const timestamp = + principalWithTimestamps.createTimestamp || + principalWithTimestamps.lastUpdateTimestamp || + (typeof principalWithTimestamps.properties?.createTimestamp === "string" + ? parseInt(principalWithTimestamps.properties.createTimestamp, 10) + : typeof principalWithTimestamps.properties?.createTimestamp === "number" + ? principalWithTimestamps.properties.createTimestamp + : typeof principalWithTimestamps.properties?.lastUpdateTimestamp === "string" + ? parseInt(principalWithTimestamps.properties.lastUpdateTimestamp, 10) + : typeof principalWithTimestamps.properties?.lastUpdateTimestamp === "number" + ? principalWithTimestamps.properties.lastUpdateTimestamp + : undefined) + + return ( + <TableRow key={principal.name}> + <TableCell className="font-medium">{principal.name}</TableCell> + <TableCell> + <Badge variant="secondary"> + {principal.properties?.serviceType || "apache-spark"} Review Comment: Thanks for the clarification. I still have questions to better understand the UX and conceptual model here. Do we really need a separate service type concept in the UI? 1. From a user’s perspective, this seems to overlap with the existing principal concept already exposed on the access control page. 2. How do we expect users to use “service type”? Given the only difference between “principal” and “service type” is having a property like `service-type=Spark` I’m trying to understand whether this duplication is intentional and beneficial from a UX perspective, or if it risks confusing users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
