dimas-b commented on code in PR #3276:
URL: https://github.com/apache/polaris/pull/3276#discussion_r2623586282
##########
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##########
@@ -137,13 +137,15 @@ public Response createCatalog(
}
private void validateClientId(String clientId) {
- if (!clientId.matches("^[0-9a-f]{16}$")) {
+ if (!clientId.matches(
+
realmConfig.getConfig(FeatureConfiguration.CREDENTIAL_RESET_CLIENT_ID_PATTERN)))
{
throw new IllegalArgumentException("Invalid clientId format");
}
}
private void validateClientSecret(String clientSecret) {
- if (!clientSecret.matches("^[0-9a-f]{32}$")) {
+ if (!clientSecret.matches(
+
realmConfig.getConfig(FeatureConfiguration.CREDENTIAL_RESET_CLIENT_SECRET_PATTERN)))
{
Review Comment:
Let's try removing the checks completely and get some more reviews. If
people raise concerns we can add an on/off flag then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
