snazy commented on code in PR #3269:
URL: https://github.com/apache/polaris/pull/3269#discussion_r2624386488
##########
persistence/nosql/authz/impl/src/test/java/org/apache/polaris/persistence/nosql/authz/impl/TestAclEntryImpl.java:
##########
@@ -39,7 +43,12 @@ public class TestAclEntryImpl {
@BeforeAll
static void setUp() {
- mapper = new ObjectMapper().findAndRegisterModules();
+ mapper =
+ JsonMapper.builder()
+ .findAndAddModules()
+ .disable(FAIL_ON_UNKNOWN_PROPERTIES)
Review Comment:
Ah, yes.
So in Jackson 2, FAIL_ON_UNKNOWN_PROPERTIES defaults to true, in Jackson 3
it defaults to false.
DEFAULT_VIEW_INCLUSION defaults to true in Jackson 2, but in Jackson 3 it
defaults to false.
TL;DR a no-op-change for Jackson 2, but a required change for Jackson 3, to
already account for these breaking changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]