rmannibucau commented on PR #3285: URL: https://github.com/apache/polaris/pull/3285#issuecomment-3662578187
@snazy yep linux (debian derivative but doesnt change the world ;)). On testing isLoopback it can be more vicious if we start to dig, personally i'm not sure why it takes all local interfaces, seems the opposite of what we do want (if I have multiple interfaces i dont want to enable them all for all apps in general) plus you need to handle links as well (a bit like tomcat does even if not 1-1 with polaris need: https://github.com/apache/tomcat/blob/cbaa713f3fa82667755cd67fa626a5b7bf07be93/java/org/apache/tomcat/util/net/AbstractEndpoint.java#L1504). So I think we can include this change (reworked or not) and then potentially rework totally this logic. Only usage (except test) is https://github.com/apache/polaris/blob/main/persistence/nosql/persistence/cdi/quarkus-distcache/src/main/java/org/apache/polaris/persistence/nosql/quarkus/distcache/CacheInvalidationSender.java#L145 and this makes it impossible to run two instances locally (which is a valid use case IMHO). Hope it makes sense, starts to be late there :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
