olsoloviov commented on code in PR #3293:
URL: https://github.com/apache/polaris/pull/3293#discussion_r2631518490
##########
runtime/service/src/main/java/org/apache/polaris/service/events/jsonEventListener/PropertyMapEventListener.java:
##########
@@ -37,10 +40,15 @@ protected abstract void transformAndSendEvent(
HashMap<String, Object> properties, PolarisEventMetadata metadata);
@Override
- public void
onAfterRefreshTable(IcebergRestCatalogEvents.AfterRefreshTableEvent event) {
- HashMap<String, Object> properties = new HashMap<>();
- properties.put("event_type", event.getClass().getSimpleName());
- properties.put("table_identifier", event.tableIdentifier().toString());
- transformAndSendEvent(properties, event.metadata());
+ public void onEvent(PolarisEvent event) {
Review Comment:
I agree. I thought it will be handled in the revived #2962, but the class
does not make any sense now so no need to keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]