pingtimeout commented on code in PR #2180: URL: https://github.com/apache/polaris/pull/2180#discussion_r2640497592
########## tasks/api/src/main/java/org/apache/polaris/tasks/api/TaskParameterTypeId.java: ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.tasks.api; + +import static java.lang.annotation.ElementType.TYPE; +import static java.lang.annotation.RetentionPolicy.RUNTIME; + +import jakarta.annotation.Nonnull; +import java.lang.annotation.Documented; +import java.lang.annotation.Retention; +import java.lang.annotation.Target; + +/** + * Provide the {@linkplain TaskBehaviorId task behavior ID} using the Review Comment: Ok so then would it make sense for the Javadoc to be "Provides the **Task Parameter ID** using the Jackson-polymorphism-mechanism" instead of "Provides the **task behavior ID** using the Jackson-polymorphism-mechanism"? I am not sure how it will be used. I suppose this and the `TaskResultTypeId` annotation could be used to find a task behaviour which uses matching parameter id and result type id. In which case the Javadoc should still be updated as the annotation does not directly provide the task behaviour id. Am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
