dimas-b commented on code in PR #114:
URL: https://github.com/apache/polaris-tools/pull/114#discussion_r2644102291
##########
console/src/api/auth.ts:
##########
@@ -2,7 +2,7 @@
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
+ * regarding copyright ownership. The ASF licenses this file
Review Comment:
spurious change?
##########
console/src/api/auth.ts:
##########
@@ -25,7 +25,7 @@ import type { OAuthTokenResponse } from "@/types/api"
// Always use relative URL to go through the proxy (dev server or production
server)
// This avoids CORS issues by proxying requests through the server
-// The server.ts proxy handles /api routes in production, and Vite handles
them in development
+// The server. ts proxy handles /api routes in production, and Vite handles
them in development
Review Comment:
Is the space intended here?
##########
console/src/api/auth.ts:
##########
@@ -98,9 +98,9 @@ export const authApi = {
refreshToken: async (accessToken: string): Promise<OAuthTokenResponse> => {
const formData = new URLSearchParams()
- formData.append("grant_type",
"urn:ietf:params:oauth:grant-type:token-exchange")
+ formData.append("grant_type", "urn:ietf:params:
oauth:grant-type:token-exchange")
formData.append("subject_token", accessToken)
- formData.append("subject_token_type",
"urn:ietf:params:oauth:token-type:access_token")
+ formData.append("subject_token_type", "urn: ietf:params:oauth:
token-type:access_token")
Review Comment:
Adding spaces makes these values invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
