singhpk234 opened a new pull request, #3334: URL: https://github.com/apache/polaris/pull/3334
### About the changes While reading code, i realized this particular check was not happening in the transaction i.e let say we observe a constrain violation because within a transaction we added some entries, we would not be able to find which entity caused the SQL constraint violation in the first place, we might get incorrect entity in the exception, though the exception remains the same. The proposed fix just uses the same conenction which is being used in the transaction and uses that to do the lookup to make sure the entity is found correctly. <!-- ๐ Describe what changes you're proposing, especially breaking or user-facing changes. ๐ See https://github.com/apache/polaris/blob/main/CONTRIBUTING.md for more. --> ## Checklist - [X] ๐ก๏ธ Don't disclose security issues! (contact [email protected]) - [X] ๐ Clearly explained why the changes are needed, or linked related issues: Fixes # - [X] ๐งช Added/updated tests with good coverage, or manually tested (and explained how) - [X] ๐ก Added comments for complex logic - [ ] ๐งพ Updated `CHANGELOG.md` (if needed) - [ ] ๐ Updated documentation in `site/content/in-dev/unreleased` (if needed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
