MonkeyCanCode commented on code in PR #3330:
URL: https://github.com/apache/polaris/pull/3330#discussion_r2648475679


##########
client/python/apache_polaris/cli/constants.py:
##########
@@ -258,6 +260,12 @@ class Create:
                 "(Only for S3) Indicates that Polaris should not use STS (e.g. 
if STS is not available)"
             )
             PATH_STYLE_ACCESS = "(Only for S3) Whether to use 
path-style-access for S3"
+            KMS_KEY_CURRENT = (

Review Comment:
   As these are optional and only for AWS, we may want to update 
`client/python/apache_polaris/cli/command/catalogs.py` as well for the function 
`_has_aws_storage_info()`. Here is a reference: 
https://github.com/apache/polaris/pull/3305/files#diff-a3e865c2a57514f7f505c706a3af70a5ac90b712f96656b513cdbfcee20c031eL181



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to